Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the replica count for kserve #2331

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix the replica count for kserve #2331

merged 1 commit into from
Jan 18, 2024

Conversation

lucferbux
Copy link
Contributor

Description

Closes https://issues.redhat.com/browse/RHOAIENG-164

How Has This Been Tested?

  1. Create a new Project
  2. Select to deploy a kserve model (single model)
  3. Change the replica count
  4. Deploy the model
  5. Now go to the openshift console, to the acutal deployment
  6. Check that the number of replicas match the ones selected
Screenshot 2024-01-09 at 23 57 36

Test Impact

Added unit testing for the assenble function

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@lucferbux lucferbux requested a review from mturley January 9, 2024 23:11
@lucferbux
Copy link
Contributor Author

@dpanshug @mturley Can you guys review this please?

@mturley
Copy link
Contributor

mturley commented Jan 16, 2024 •
edited
Loading

@lucferbux the code LGTM, but I'm having an issue testing it locally.

  • Testing on the real cluster-hosted UI (kserve-pm), I can reproduce the bug (the deployment gets created with 1 pod instead of 2 when I specify 2 replicas).
  • Testing on both the main branch and the PR branch with my local UI pointed at the same cluster (kserve-pm), the deployment never gets created regardless of how many replicas I specify.

@lucferbux
Copy link
Contributor Author

@lucferbux the code LGTM, but I'm having an issue testing it locally.

  • Testing on the real cluster-hosted UI (kserve-pm), I can reproduce the bug (the deployment gets created with 1 pod instead of 2 when I specify 2 replicas).
  • Testing on both the main branch and the PR branch with my local UI pointed at the same cluster (kserve-pm), the deployment never gets created regardless of how many replicas I specify.

@mturley I've just tested it and it should be working, test it with low replicas to be able to deploy it.

Screenshot 2024-01-17 at 18 37 02

mturley
mturley approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@mturley mturley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed my local issue, I had the wrong namespace in my .env.local. Verified the fix and LGTM aside from merge conflicts.

@openshift-ci openshift-ci bot added the lgtm label Jan 17, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Jan 17, 2024
@openshift-ci openshift-ci bot removed the lgtm label Jan 18, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Jan 18, 2024
@lucferbux
Copy link
Contributor Author

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

@lucferbux: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucferbux
Copy link
Contributor Author

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mturley
Copy link
Contributor

mturley commented Jan 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7339370 into opendatahub-io:main Jan 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturley mturley mturley approved these changes

@DaoDaoNoCode DaoDaoNoCode Awaiting requested review from DaoDaoNoCode

@dpanshug dpanshug Awaiting requested review from dpanshug

Assignees

@mturley mturley

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucferbux @mturley @openshift-merge-robot